Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Andy Lutomirski
On Mon, Feb 25, 2019 at 8:37 AM Peter Zijlstra wrote: > > On Mon, Feb 25, 2019 at 08:29:12AM -0800, Andy Lutomirski wrote: > > > > diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c > > > index 321fe5f5d0e9..e04eeeddcc35 100644 > > > --- a/arch/x86/ia32/ia32_signal.c > > > +++

Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Peter Zijlstra
On Mon, Feb 25, 2019 at 05:37:45PM +0100, Peter Zijlstra wrote: > + RELOAD_SEG(gs); > + RELOAD_SEG(fs); > + RELOAD_SEG(ds); > + RELOAD_SEG(es); Also; is that the canonical order ? It bugs the hell out of me to not have that alphabetically correct. Shall I correct that?

Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Peter Zijlstra
On Mon, Feb 25, 2019 at 08:29:12AM -0800, Andy Lutomirski wrote: > > diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c > > index 321fe5f5d0e9..e04eeeddcc35 100644 > > --- a/arch/x86/ia32/ia32_signal.c > > +++ b/arch/x86/ia32/ia32_signal.c > > @@ -53,17 +53,16 @@ > > #define GE

Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Andy Lutomirski
> On Feb 25, 2019, at 8:10 AM, Peter Zijlstra wrote: > >> On Mon, Feb 25, 2019 at 07:41:50AM -0800, Andy Lutomirski wrote: >> This is so tangled. >> >> How about changing RELOAD_SEG to replace unsigned int pre = >> GET_SEG(seg); with unsigned int pre = (seg); to make it less magic. >> Then d

Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Peter Zijlstra
On Mon, Feb 25, 2019 at 07:41:50AM -0800, Andy Lutomirski wrote: > This is so tangled. > > How about changing RELOAD_SEG to replace unsigned int pre = > GET_SEG(seg); with unsigned int pre = (seg); to make it less magic. > Then do: > > unsigned int gs = GET_SEG(gs); > > ... > > RELOAD_SEG(gs);

Re: [PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Andy Lutomirski
On Mon, Feb 25, 2019 at 4:53 AM Peter Zijlstra wrote: > > Don't call load_gs_index() with AC set; delay the segment setting > until after the AC section. > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/ia32/ia32_signal.c | 29 +++-- > 1 file changed, 19 inser

[PATCH 2/6] x86/ia32: Fix ia32_restore_sigcontext AC leak

2019-02-25 Thread Peter Zijlstra
Don't call load_gs_index() with AC set; delay the segment setting until after the AC section. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/ia32/ia32_signal.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) --- a/arch/x86/ia32/ia32_signal.c +++ b/arc