Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-11-30 Thread Andy Shevchenko
On Tue, Oct 4, 2016 at 12:50 AM, Simon Glass wrote: > HI Matt, > > On 16 August 2016 at 20:25, Matt Mullins wrote: >> On Tue, Aug 16, 2016 at 12:19:42PM -0700, Yinghai Lu wrote: >>> On Mon, Aug 15, 2016 at 9:01 PM, Matt Mullins wrote: >>> > >>> > This appears to have a negative effect on booting

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-10-03 Thread Simon Glass
HI Matt, On 16 August 2016 at 20:25, Matt Mullins wrote: > On Tue, Aug 16, 2016 at 12:19:42PM -0700, Yinghai Lu wrote: >> On Mon, Aug 15, 2016 at 9:01 PM, Matt Mullins wrote: >> > >> > This appears to have a negative effect on booting the Intel Edison >> > platform, as >> > it uses u-boot as it

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-08-16 Thread Matt Mullins
On Tue, Aug 16, 2016 at 12:19:42PM -0700, Yinghai Lu wrote: > On Mon, Aug 15, 2016 at 9:01 PM, Matt Mullins wrote: > > > > This appears to have a negative effect on booting the Intel Edison > > platform, as > > it uses u-boot as its bootloader. u-boot does not copy the init_size > > parameter >

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-08-16 Thread Yinghai Lu
On Mon, Aug 15, 2016 at 9:01 PM, Matt Mullins wrote: > > This appears to have a negative effect on booting the Intel Edison platform, > as > it uses u-boot as its bootloader. u-boot does not copy the init_size > parameter > when booting a bzImage: it copies a fixed-size setup_header [1], and it

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-08-15 Thread Matt Mullins
[added Simon Glass to CC in case there's some input from u-boot] On Thu, Apr 28, 2016 at 05:09:04PM -0700, Kees Cook wrote: > From: Yinghai Lu > > This patch adds BP_init_size (which is the INIT_SIZE as passed in from > the boot_params) into asm-offsets.c to make it visible to the assembly > cod

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-04-29 Thread Ingo Molnar
* Ingo Molnar wrote: > * Kees Cook wrote: > > > I don't agree. We do still have embedded systems running x86 kernels, and > > we > > have cases where we're running multiple kernels in memory (like kdump). I > > think > > the memory savings is worth the complexity, especially since the comp

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-04-29 Thread Ingo Molnar
* Kees Cook wrote: > I don't agree. We do still have embedded systems running x86 kernels, and we > have cases where we're running multiple kernels in memory (like kdump). I > think > the memory savings is worth the complexity, especially since the complexity > is > being reduced up by this

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-04-29 Thread Kees Cook
On Fri, Apr 29, 2016 at 12:18 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> From: Yinghai Lu >> >> This change makes later calculations about where the kernel is located >> easier to reason about. To better understand this change, we must first >> clarify what VO and ZO are. They were intro

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-04-29 Thread Ingo Molnar
* Kees Cook wrote: > From: Yinghai Lu > > This change makes later calculations about where the kernel is located > easier to reason about. To better understand this change, we must first > clarify what VO and ZO are. They were introduced in commits by hpa: > > 77d1a49 x86, boot: make symbols

[PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-04-28 Thread Kees Cook
From: Yinghai Lu This change makes later calculations about where the kernel is located easier to reason about. To better understand this change, we must first clarify what VO and ZO are. They were introduced in commits by hpa: 77d1a49 x86, boot: make symbols from the main vmlinux available 37ba