Re: [External] Re: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-05 Thread Muchun Song
On Wed, Jan 6, 2021 at 6:29 AM Mike Kravetz wrote: > > On 1/4/21 6:44 PM, Muchun Song wrote: > > On Tue, Jan 5, 2021 at 6:40 AM Mike Kravetz wrote: > >> > >> On 1/3/21 10:58 PM, Muchun Song wrote: > >>> Because we only can isolate a active page via isolate_huge_page() > >>> and hugetlbfs_fallocat

Re: [External] Re: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-05 Thread Mike Kravetz
On 1/4/21 6:44 PM, Muchun Song wrote: > On Tue, Jan 5, 2021 at 6:40 AM Mike Kravetz wrote: >> >> On 1/3/21 10:58 PM, Muchun Song wrote: >>> Because we only can isolate a active page via isolate_huge_page() >>> and hugetlbfs_fallocate() forget to mark it as active, we cannot >>> isolate and migrate

Re: [External] Re: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-04 Thread Muchun Song
On Tue, Jan 5, 2021 at 6:40 AM Mike Kravetz wrote: > > On 1/3/21 10:58 PM, Muchun Song wrote: > > Because we only can isolate a active page via isolate_huge_page() > > and hugetlbfs_fallocate() forget to mark it as active, we cannot > > isolate and migrate those pages. > > > > Fixes: 70c3547e36f5

Re: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-04 Thread Mike Kravetz
On 1/3/21 10:58 PM, Muchun Song wrote: > Because we only can isolate a active page via isolate_huge_page() > and hugetlbfs_fallocate() forget to mark it as active, we cannot > isolate and migrate those pages. > > Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate()) > Signed-off-by: Muchun So

[PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-03 Thread Muchun Song
Because we only can isolate a active page via isolate_huge_page() and hugetlbfs_fallocate() forget to mark it as active, we cannot isolate and migrate those pages. Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate()) Signed-off-by: Muchun Song --- fs/hugetlbfs/inode.c | 5 +++-- 1 file cha