Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-20 Thread One Thousand Gnomes
On Mon, 20 Jun 2016 11:29:28 +0200 (CEST) Jiri Kosina wrote: > On Fri, 17 Jun 2016, Srinivas Pandruvada wrote: > > > > > +config INTEL_ISH_HID_TRANSPORT > > > > + bool > > > > + default n > > > > + > > > > +config INTEL_ISH_HID > > > > + bool "Intel Integrated Sensor Hub" > > > >

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-20 Thread Jiri Kosina
On Fri, 17 Jun 2016, Srinivas Pandruvada wrote: > > > +config INTEL_ISH_HID_TRANSPORT > > > + bool > > > + default n > > > + > > > +config INTEL_ISH_HID > > > + bool "Intel Integrated Sensor Hub" > > > > Why can't the transport driver be built as a module? > In current use case for PM

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-17 Thread Srinivas Pandruvada
On Fri, 2016-06-17 at 22:43 +0200, Jiri Kosina wrote: > On Sat, 11 Jun 2016, Srinivas Pandruvada wrote: > > [ ... snip ... ] > > diff --git a/drivers/hid/intel-ish-hid/Kconfig b/drivers/hid/intel- > ish-hid/Kconfig > > new file mode 100644 > > index 000..8914f3b > > --- /dev/null > > +++ b/dri

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-17 Thread Srinivas Pandruvada
On Fri, 2016-06-17 at 22:45 +0200, Jiri Kosina wrote: > On Fri, 17 Jun 2016, Jiri Kosina wrote: > > > > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device > *dev, > > > +    uuid_le uuid, char > *name) > > > +{ > >  > > Should be static. > > Actu

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-17 Thread Jiri Kosina
On Sat, 11 Jun 2016, Srinivas Pandruvada wrote: [ ... snip ... ] > diff --git a/drivers/hid/intel-ish-hid/Kconfig > b/drivers/hid/intel-ish-hid/Kconfig > new file mode 100644 > index 000..8914f3b > --- /dev/null > +++ b/drivers/hid/intel-ish-hid/Kconfig > @@ -0,0 +1,22 @@ > +menu "Intel ISH H

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-17 Thread Jiri Kosina
On Fri, 17 Jun 2016, Jiri Kosina wrote: > > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev, > > +uuid_le uuid, char *name) > > +{ > > Should be static. Actually, going deeper into the code and trying to untangle all the dependencie

[PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

2016-06-11 Thread Srinivas Pandruvada
From: Daniel Drubin The ISH transport layer (ishtp) is a bi-directional protocol implemented on the top of PCI based inter processor communication layer. This layer offers: - Connection management - Flow control with the firmware - Multiple client sessions - Client message transfer - Client messa