Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic

2016-08-30 Thread Tomi Valkeinen
On 29/08/16 16:18, Linus Walleij wrote: > On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann wrote: > > [I don't see why Torvalds was CC'ed on this patch? Was there > some specific complaint from his side that I screw things up > or just the wrong Linus?] > >> The addition of the Nomadik support in

Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic

2016-08-29 Thread Arnd Bergmann
On Monday 29 August 2016, Linus Walleij wrote: > On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann wrote: > > [I don't see why Torvalds was CC'ed on this patch? Was there > some specific complaint from his side that I screw things up > or just the wrong Linus?] It was intentional: as mentioned in t

Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic

2016-08-29 Thread Linus Walleij
On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann wrote: [I don't see why Torvalds was CC'ed on this patch? Was there some specific complaint from his side that I screw things up or just the wrong Linus?] > The addition of the Nomadik support in this driver introduced > a bug in clcdfb_of_init_disp

[PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic

2016-08-26 Thread Arnd Bergmann
The addition of the Nomadik support in this driver introduced a bug in clcdfb_of_init_display(), which now calls init_panel with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" warns: drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': drivers/video/fbdev/amb