Re: [PATCH 2/5] e1000e: fix pci device enable counter balance

2013-01-30 Thread Rafael J. Wysocki
On Monday, January 28, 2013 04:09:38 PM Bjorn Helgaas wrote: > [+cc Rafael] > > On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov > wrote: > > __e1000_shutdown() calls pci_disable_device() at the end, thus > > __e1000_resume() > > should call pci_enable_device_mem() to keep enable counter i

Re: [PATCH 2/5] e1000e: fix pci device enable counter balance

2013-01-28 Thread Konstantin Khlebnikov
Bjorn Helgaas wrote: [+cc Rafael @sisk.pl] On Mon, Jan 28, 2013 at 4:09 PM, Bjorn Helgaas wrote: [+cc Rafael] On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov wrote: __e1000_shutdown() calls pci_disable_device() at the end, thus __e1000_resume() should call pci_enable_device_mem() to

Re: [PATCH 2/5] e1000e: fix pci device enable counter balance

2013-01-28 Thread Bjorn Helgaas
[+cc Rafael @sisk.pl] On Mon, Jan 28, 2013 at 4:09 PM, Bjorn Helgaas wrote: > [+cc Rafael] > > On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov > wrote: >> __e1000_shutdown() calls pci_disable_device() at the end, thus >> __e1000_resume() >> should call pci_enable_device_mem() to keep ena

Re: [PATCH 2/5] e1000e: fix pci device enable counter balance

2013-01-28 Thread Bjorn Helgaas
[+cc Rafael] On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov wrote: > __e1000_shutdown() calls pci_disable_device() at the end, thus > __e1000_resume() > should call pci_enable_device_mem() to keep enable counter in balance. > > Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f

[PATCH 2/5] e1000e: fix pci device enable counter balance

2013-01-18 Thread Konstantin Khlebnikov
__e1000_shutdown() calls pci_disable_device() at the end, thus __e1000_resume() should call pci_enable_device_mem() to keep enable counter in balance. Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133 ("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in v2.6.35 Sign