Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

2013-12-13 Thread Robin Holt
On Fri, Dec 13, 2013 at 2:56 AM, Josh Triplett wrote: > On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote: >> This patch marks the function xp_init() and xp_exit() as static in >> sgi-xp/xp_main.c because they are not used outside this file. >> >> Thus, it also eliminates the followin

Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

2013-12-13 Thread Josh Triplett
On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote: > This patch marks the function xp_init() and xp_exit() as static in > sgi-xp/xp_main.c because they are not used outside this file. > > Thus, it also eliminates the following warnings in sgi-xp/xp_main.c: > drivers/misc/sgi-xp/xp_mai

[PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

2013-12-12 Thread Rashika Kheria
This patch marks the function xp_init() and xp_exit() as static in sgi-xp/xp_main.c because they are not used outside this file. Thus, it also eliminates the following warnings in sgi-xp/xp_main.c: drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-protot