Re: [PATCH 2/5] KVM: add KVM request variants without barrier

2017-02-23 Thread Radim Krčmář
2017-02-23 11:57+0100, Paolo Bonzini: > On 16/02/2017 17:04, Radim Krčmář wrote: >> + >> +static inline void __kvm_request_clear(unsigned req, struct kvm_vcpu *vcpu) >> +{ >> +test_bit(req, &vcpu->requests); >> } > > Are you sure? :) No, as always. :)

Re: [PATCH 2/5] KVM: add KVM request variants without barrier

2017-02-23 Thread Paolo Bonzini
On 16/02/2017 17:04, Radim Krčmář wrote: > + > +static inline void __kvm_request_clear(unsigned req, struct kvm_vcpu *vcpu) > +{ > + test_bit(req, &vcpu->requests); > } Are you sure? :) Paolo > static inline bool kvm_request_test_and_clear(unsigned req, struct kvm_vcpu > *vcpu) > { > -

[PATCH 2/5] KVM: add KVM request variants without barrier

2017-02-16 Thread Radim Krčmář
The leading underscores mean that the call is just a bitop wrapper. Switch all users of open-coded set/check/test to kvm_request ones. Automated by coccinelle script: @@ expression VCPU, REQ; @@ -set_bit(REQ, &VCPU->requests) +__kvm_request_set(REQ, VCPU) @@ expression VCPU, REQ;