Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread Sergei Shtylyov
On 03/16/2016 08:58 PM, David Lechner wrote: +static struct clk usb20_clk = { +.name= "usb20", +.parent= &pll0_sysclk2, +.lpsc= DA8XX_LPSC1_USB20, +.gpsc= 1, +}; Why move it? For organization, to keep all of the USB clocks together. I can l

Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread Sergei Shtylyov
Hello. On 3/16/2016 1:37 AM, David Lechner wrote: Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the r

Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread David Lechner
On 03/16/2016 01:04 PM, Sergei Shtylyov wrote: No, I mean why is not this implemented as a part of clk_set_parent()? There is not currently any framework for mux clocks in the davinci clocks. I am hoping to eventually get the davinci clocks moved to the common clock framework, so this w

Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread David Lechner
On 03/16/2016 07:27 AM, Sergei Shtylyov wrote: +static struct clk usb20_clk = { +.name= "usb20", +.parent= &pll0_sysclk2, +.lpsc= DA8XX_LPSC1_USB20, +.gpsc= 1, +}; Why move it? For organization, to keep all of the USB clocks together. I can

[PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

2016-03-15 Thread David Lechner
Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the related code is removed from the board files. Signed-o