Re: [PATCH 2/4 v5] devpts: resolve devpts bind-mounts

2018-03-13 Thread Eric W. Biederman
Christian Brauner writes: Reviewed-by: "Eric W. Biederman" It would have been more readable if Linus's suggested cleanup were in a separate patch. But unless you need to respin I would not worry about that. > Most libcs will still look at /dev/ptmx when opening the master fd of a pty > device

[PATCH 2/4 v5] devpts: resolve devpts bind-mounts

2018-03-13 Thread Christian Brauner
Most libcs will still look at /dev/ptmx when opening the master fd of a pty device. When /dev/ptmx is a bind-mount of /dev/pts/ptmx and the TIOCGPTPEER ioctl() is used to safely retrieve a file descriptor for the slave side of the pty based on the master fd, the /proc/self/fd/{0,1,2} symlinks will