Re: [PATCH 2/4] workqueue: don't check wq->rescuer in rescuer

Hello, On Fri, May 29, 2020 at 10:58:46PM +0800, Lai Jiangshan wrote: > I'm not sure I understood your words. And I'm not > sure which function may use freed object in "use-after-free". > Is it "send_mayday() may use a freed rescuer"? > > This patch relies on > def98c84b6 ("workqueue: Fix spuriou

Re: [PATCH 2/4] workqueue: don't check wq->rescuer in rescuer

On Fri, May 29, 2020 at 10:14 PM Tejun Heo wrote: > > On Fri, May 29, 2020 at 06:59:00AM +, Lai Jiangshan wrote: > > Now rescuer checks pwq->nr_active before requeues the pwq, > > it is a more robust check and the rescuer must be still valid. > > > > Signed-off-by: Lai Jiangshan > > --- > >

Re: [PATCH 2/4] workqueue: don't check wq->rescuer in rescuer

On Fri, May 29, 2020 at 06:59:00AM +, Lai Jiangshan wrote: > Now rescuer checks pwq->nr_active before requeues the pwq, > it is a more robust check and the rescuer must be still valid. > > Signed-off-by: Lai Jiangshan > --- > kernel/workqueue.c | 23 +-- > 1 file changed,

[PATCH 2/4] workqueue: don't check wq->rescuer in rescuer

Now rescuer checks pwq->nr_active before requeues the pwq, it is a more robust check and the rescuer must be still valid. Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/kernel/workqueue.c b/kernel/w