On Wed, Dec 20, 2017 at 07:26:03PM +0100, Javier Martinez Canillas wrote:
> On 12/20/2017 07:10 PM, Jason Gunthorpe wrote:
> > On Wed, Dec 20, 2017 at 03:19:19PM +, Shaikh, Azhar wrote:
> >>> This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> >>> systems, but the only way
On Wed, Dec 20, 2017 at 12:35:36PM +0100, Javier Martinez Canillas wrote:
> This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> systems, but the only way this can happen is if the code is not correct.
>
> So it's an unnecessary check that just makes the code harder to read.
>
On 12/20/2017 07:10 PM, Jason Gunthorpe wrote:
> On Wed, Dec 20, 2017 at 03:19:19PM +, Shaikh, Azhar wrote:
>>> This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
>>> systems, but the only way this can happen is if the code is not correct.
>>>
>>> So it's an unnecessary che
On Wed, Dec 20, 2017 at 03:19:19PM +, Shaikh, Azhar wrote:
> >This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> >systems, but the only way this can happen is if the code is not correct.
> >
> >So it's an unnecessary check that just makes the code harder to read.
>
> Thi
o Sakkinen ; Peter Huewe
>; Jason Gunthorpe ; Greg Kroah-
>Hartman ; linux-integr...@vger.kernel.org
>Subject: [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag
>
>This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
>systems, but the only way this can happ
This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
systems, but the only way this can happen is if the code is not correct.
So it's an unnecessary check that just makes the code harder to read.
Suggested-by: Jarkko Sakkinen
Signed-off-by: Javier Martinez Canillas
---
driv
6 matches
Mail list logo
