Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Lee Jones
On Tue, 02 Jul 2019, Lothar Waßmann wrote: > Hi, > > On Tue, 2 Jul 2019 19:47:16 +0800 Fuqian Huang wrote: > > Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > > > > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang > > > wrote: > > > > > > > > I am not an expert on this. I just write a coccinelle s

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Lothar Waßmann
Hi, On Tue, 2 Jul 2019 19:47:16 +0800 Fuqian Huang wrote: > Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang > > wrote: > > > > > > I am not an expert on this. I just write a coccinelle script to search > > > this kind of misuse and fix it in a naiv

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Andy Shevchenko
On Tue, Jul 2, 2019 at 2:47 PM Fuqian Huang wrote: > > Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang > > wrote: > > > > > > I am not an expert on this. I just write a coccinelle script to search > > > this kind of misuse and fix it in a naive way.

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Fuqian Huang
Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang wrote: > > > > I am not an expert on this. I just write a coccinelle script to search > > this kind of misuse and fix it in a naive way. > > Could you tell me about how to use the proper bus accessors? Then I

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Andy Shevchenko
On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang wrote: > > I am not an expert on this. I just write a coccinelle script to search > this kind of misuse and fix it in a naive way. > Could you tell me about how to use the proper bus accessors? Then I > will fix it up and resend a v2 patch set. First,

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Fuqian Huang
I am not an expert on this. I just write a coccinelle script to search this kind of misuse and fix it in a naive way. Could you tell me about how to use the proper bus accessors? Then I will fix it up and resend a v2 patch set. Thanks. Dmitry Torokhov 於 2019年7月1日週一 下午3:52寫道： > > Hi Fuqian, > > O

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-01 Thread Dmitry Torokhov
Hi Fuqian, On Mon, Jul 01, 2019 at 11:23:12AM +0800, Fuqian Huang wrote: > Using dev_get_drvdata directly. > I prefer using proper bus accessors. Thanks. -- Dmitry

[PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-06-30 Thread Fuqian Huang
Using dev_get_drvdata directly. Signed-off-by: Fuqian Huang --- drivers/input/keyboard/ep93xx_keypad.c | 10 -- drivers/input/keyboard/gpio_keys.c | 3 +-- drivers/input/keyboard/imx_keypad.c | 10 -- drivers/input/keyboard/lpc32xx-keys.c| 6 ++ drivers/inp