Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Thu, Nov 7, 2013 at 12:13 PM, Wolfram Sang wrote: > OK. Then please change the error message for unsupported bus speeds to > contain the supported ones. I don't think it is good practice to force > users to look into the sourcecode to find this information. That works for me. Thanks. -Tim -

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Wolfram Sang
> While the bus speed property is really a configuration parameter (and > not a true description of of the hardware) it seems improper to put > driver specific details into the binding document. OK. Then please change the error message for unsupported bus speeds to contain the supported ones. I d

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Fri, Nov 1, 2013 at 6:08 AM, Wolfram Sang wrote: > On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote: >> Add support for I2C high-speed mode (3.4 MHz). >> >> Signed-off-by: Tim Kryger >> Reviewed-by: Matt Porter >> Reviewed-by: Markus Mayer > > Mostly good as well: > >> +enum hs_bus

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-01 Thread Wolfram Sang
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote: > Add support for I2C high-speed mode (3.4 MHz). > > Signed-off-by: Tim Kryger > Reviewed-by: Matt Porter > Reviewed-by: Markus Mayer Mostly good as well: > +enum hs_bus_speed_index { > + BCM_SPD_3P4MHZ = 0, > +}; I just realize

[RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-10-16 Thread Tim Kryger
Add support for I2C high-speed mode (3.4 MHz). Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/i2c/busses/i2c-bcm-kona.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/d

[PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-10-07 Thread Tim Kryger
Add support for I2C high-speed mode (3.4 MHz). Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/i2c/busses/i2c-bcm-kona.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/d