Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-21 Thread Jisheng Zhang
Dear Jarkko, On Thu, 21 Apr 2016 10:39:50 +0300 Jarkko Nikula wrote: > On 04/21/2016 05:40 AM, Jisheng Zhang wrote: > > Dear Jarkko, Andy, > > > > On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote: > > > >> On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: > >>> I see Andy's 1cb7

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-21 Thread Jarkko Nikula
On 04/21/2016 05:40 AM, Jisheng Zhang wrote: Dear Jarkko, Andy, On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote: On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions (devm_*)") removed it but at quick look drive

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-20 Thread Jisheng Zhang
Dear Jarkko, Andy, On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote: > On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: > > On 04/14/2016 03:53 PM, Jisheng Zhang wrote: > > > > > > If i2c_dw_probe() fail, we should call i2c_dw_plat_prepare_clk() to > > > disable and unprepare th

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-20 Thread Andy Shevchenko
On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: > On 04/14/2016 03:53 PM, Jisheng Zhang wrote: > > > > If i2c_dw_probe() fail, we should call i2c_dw_plat_prepare_clk() to > > disable and unprepare the clk, otherwise the clk enable and prepare > > is left unbalanced. > > > > Signed-off-by:

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-20 Thread Jarkko Nikula
On 04/14/2016 03:53 PM, Jisheng Zhang wrote: If i2c_dw_probe() fail, we should call i2c_dw_plat_prepare_clk() to disable and unprepare the clk, otherwise the clk enable and prepare is left unbalanced. Signed-off-by: Jisheng Zhang --- drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++ 1 file

[PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-14 Thread Jisheng Zhang
If i2c_dw_probe() fail, we should call i2c_dw_plat_prepare_clk() to disable and unprepare the clk, otherwise the clk enable and prepare is left unbalanced. Signed-off-by: Jisheng Zhang --- drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i