Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2020-08-25 Thread Phil Reid
On 25/08/2020 21:28, Wolfram Sang wrote: Hi Phil, yes, this thread is old but a similar issue came up again... On Fri, Oct 25, 2019 at 09:14:00AM +0800, Phil Reid wrote: So at the beginning of a new transfer, we should check if SDA (or SCL?) is low and, if it's true, only then we should try

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2020-08-25 Thread Wolfram Sang
Hi Phil, yes, this thread is old but a similar issue came up again... On Fri, Oct 25, 2019 at 09:14:00AM +0800, Phil Reid wrote: > > > > > So at the beginning of a new transfer, we should check if SDA (or SCL?) > > > is low and, if it's true, only then we should try recover the bus. > > > > Ye

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-21 Thread Wolfram Sang
On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > Implement i2c bus recovery when slaves devices might hold SDA low. > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > until the slave release SDA. > > Signed-off-by: Kamel Bouhara Setting up the bus_recovery

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 09, 2019 at 04:01:47PM +0200, Alexandre Belloni wrote: > > On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > > External E-Mail > > > > > > > > > Implement i2c bus recovery when slaves devices might hold SDA lo

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Alexandre Belloni
On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > External E-Mail > > > > > > Implement i2c bus recovery when slaves devices might hold SDA low. > > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > >

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > External E-Mail > > > Implement i2c bus recovery when slaves devices might hold SDA low. > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > until the slave release SDA. > Hi Kamel, Thanks for adding this n

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-07 Thread Claudiu.Beznea
On 04.10.2019 23:39, Uwe Kleine-König wrote: > External E-Mail > > > On Fri, Oct 04, 2019 at 09:35:23AM +, claudiu.bez...@microchip.com wrote: >> Hi Kamel, >> >> On 02.10.2019 17:46, Kamel Bouhara wrote: >>> +static int at91_init_twi_recovery_info(struct platform_device *pdev, >>> +

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 09:35:23AM +, claudiu.bez...@microchip.com wrote: > Hi Kamel, > > On 02.10.2019 17:46, Kamel Bouhara wrote: > > +static int at91_init_twi_recovery_info(struct platform_device *pdev, > > + struct at91_twi_dev *dev) > > +{ > > + struct i

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-04 Thread Claudiu.Beznea
Hi Kamel, On 02.10.2019 17:46, Kamel Bouhara wrote: > +static int at91_init_twi_recovery_info(struct platform_device *pdev, > +struct at91_twi_dev *dev) > +{ > + struct i2c_bus_recovery_info *rinfo = &dev->rinfo; > + > + dev->pinctrl = devm_pinctrl_get(&

[PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-02 Thread Kamel Bouhara
Implement i2c bus recovery when slaves devices might hold SDA low. In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses until the slave release SDA. Signed-off-by: Kamel Bouhara --- drivers/i2c/busses/i2c-at91-master.c | 63 drivers/i2c/busses/i2c-a