Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-22 Thread Francois Romieu
> diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h > new file mode 100644 > index 000..0450b77 > --- /dev/null > +++ b/drivers/net/atl1/atl1_hw.h [...] > +/* MII definition */ > +/* PHY Common Register */ > +#define MII_BMCR 0x00 > +#defi

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- atl1.h| 288 +++

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Francois Romieu wrote: Jay Cliburn <[EMAIL PROTECTED]> : [...] I welcome any comments on the rationality of this approach. An URL for the current version of the patch would be welcome too :o) Sorry. Forgot to do that. The current version may be found here: ftp://hogchain.net/pub/linux/m2

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Francois Romieu
Jay Cliburn <[EMAIL PROTECTED]> : [...] > I welcome any comments on the rationality of this approach. An URL for the current version of the patch would be welcome too :o) -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Christoph Hellwig wrote: On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: +struct csum_param { + unsigned buf_len:14; + unsigned dma_int:1; + unsigned pkt_int:1; + u16 valan_tag; + unsigned eop:1; + /* command */ + unsigned coalese:1; +

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
On Thu, Jan 11, 2007 at 10:53:30AM -0600, Jay Cliburn wrote: > On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > > +/** > > > + * atl1.h - atl1 main header > > > > Please remove these kind of comments, they get o

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Stephen Hemminger
On Thu, 11 Jan 2007 10:53:30 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > > +/** > > > + * atl1.h - atl1 main header > > > > Please remove these kind of commen

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Jay Cliburn
On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > +/** > > + * atl1.h - atl1 main header > > Please remove these kind of comments, they get out of date far too soon > and don't really help anything. (Also everywhe

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > +/** > + * atl1.h - atl1 main header Please remove these kind of comments, they get out of date far too soon and don't really help anything. (Also everywhere else in the driver) > +#include > +#include > +#include > +#include > +

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- atl1.h| 266 +++

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2006-11-19 Thread Jan Engelhardt
On Nov 19 2006 14:30, Jay Cliburn wrote: >+ >+#define LBYTESWAP( a ) ( ( ( (a) & 0x00ff00ff ) << 8 ) | ( ( (a) & >0xff00ff00 ) >> 8 ) ) >+#define LONGSWAP( a ) ( ( LBYTESWAP( a ) << 16 ) | ( LBYTESWAP( a ) >>> 16 ) ) >+#define SHORTSWAP( a ) ( ( (a) << 8 ) | ( (a) >> 8 ) )

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- atl1.h | 251 ++ atl1_hw.h| 991 ++