Re: [Linux-kernel] [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Ben Dooks
On 2018-07-30 16:07, Mark Brown wrote: On Mon, Jul 30, 2018 at 03:04:46PM +0100, Jon Hunter wrote: On 30/07/18 11:18, Mark Brown wrote: > DSP modes only care about the rising edge of the LRCLK, the pulse can be > any width without causing interoperability problems. OK, thanks I was not a

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Mark Brown
On Mon, Jul 30, 2018 at 03:04:46PM +0100, Jon Hunter wrote: > On 30/07/18 11:18, Mark Brown wrote: > > DSP modes only care about the rising edge of the LRCLK, the pulse can be > > any width without causing interoperability problems. > OK, thanks I was not able to find a spec that defines this, bu

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Jon Hunter
On 30/07/18 15:04, Jon Hunter wrote: > I still do not like configuring the fsync width in this function. The > fsync width needs to be configured for both DSP modes and normal I2S > modes and so it seems it would be more appropriate to do this in the > hw_params function for this driver. That sa

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Jon Hunter
On 30/07/18 11:18, Mark Brown wrote: > On Mon, Jul 30, 2018 at 10:31:16AM +0100, Jon Hunter wrote: > >> It can be quite common for the fsync-width for DSP modes to be a single >> clock and so >> I am not sure that is makes sense to set this here always to the slot width. >> It maybe >> worth

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Mark Brown
On Mon, Jul 30, 2018 at 10:31:16AM +0100, Jon Hunter wrote: > It can be quite common for the fsync-width for DSP modes to be a single clock > and so > I am not sure that is makes sense to set this here always to the slot width. > It maybe > worth considering add a DT property for specifying the

Re: [alsa-devel] [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Ben Dooks
On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote: > On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote: > > From: Edward Cragg > > > > Add a callback to configure TDM settings for the Tegra30 > > I2S ASoC 'platform' driver. > > > > Signed-off-by: Ben Dooks > > Signed-off-by

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Jon Hunter
On 27/07/18 13:59, Jorge Sanjuan wrote: > From: Edward Cragg > > Add a callback to configure TDM settings for the Tegra30 > I2S ASoC 'platform' driver. > > Signed-off-by: Ben Dooks > Signed-off-by: Edward Cragg > [jorge.sanj...@codethink.co.uk: Style fixes] > Signed-off-by: Jorge Sanjuan >

Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-30 Thread Mark Brown
On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote: > From: Edward Cragg > > Add a callback to configure TDM settings for the Tegra30 > I2S ASoC 'platform' driver. > > Signed-off-by: Ben Dooks > Signed-off-by: Edward Cragg This says it was britten by Edward but there's a signoff fr

[PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

2018-07-27 Thread Jorge Sanjuan
From: Edward Cragg Add a callback to configure TDM settings for the Tegra30 I2S ASoC 'platform' driver. Signed-off-by: Ben Dooks Signed-off-by: Edward Cragg [jorge.sanj...@codethink.co.uk: Style fixes] Signed-off-by: Jorge Sanjuan --- sound/soc/tegra/tegra30_i2s.c | 34 ++