Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-08-01 Thread Ingo Molnar
* Peter Zijlstra wrote: > > > I yelled at BIOS engineers over their PMU usage and $vendor > > > added a BIOS knob to disable that, I'll yell at BIOS engineers > > > again, just give me their number. > > > > > > Really, say NO already. > > > > Ok, so no technical reason, merely a "me vs you"

Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-08-01 Thread Peter Zijlstra
On Fri, Aug 01, 2014 at 03:21:20PM +0200, Andi Kleen wrote: > > > NAK! > > > > > > I already said this isn't going to ever happen. > > > > > > Both PT and LBR are arbitrated through the kernel, therefore we can (and > > > must) deny PT when there's existing LBR usage and vice versa. > > > > > >

Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-08-01 Thread Andi Kleen
> > NAK! > > > > I already said this isn't going to ever happen. > > > > Both PT and LBR are arbitrated through the kernel, therefore we can (and > > must) deny PT when there's existing LBR usage and vice versa. > > > > We will not hijack resources like this full stop end of story. > > > > Fuck

Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-08-01 Thread Peter Zijlstra
On Fri, Aug 01, 2014 at 09:38:25AM +0200, Peter Zijlstra wrote: > On Thu, Jul 31, 2014 at 02:41:02AM -0700, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Intel PT will take over LBR hardware. If RTIT_CTL.TraceEn=1, any attempt to > > read or write the LBR or LER MSRs, including LBR_TOS,

Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-08-01 Thread Peter Zijlstra
On Thu, Jul 31, 2014 at 02:41:02AM -0700, kan.li...@intel.com wrote: > From: Kan Liang > > Intel PT will take over LBR hardware. If RTIT_CTL.TraceEn=1, any attempt to > read or write the LBR or LER MSRs, including LBR_TOS, will result in a #GP. > Intel PT can be enabled/disabled at runtime by har

[PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

2014-07-31 Thread kan . liang
From: Kan Liang Intel PT will take over LBR hardware. If RTIT_CTL.TraceEn=1, any attempt to read or write the LBR or LER MSRs, including LBR_TOS, will result in a #GP. Intel PT can be enabled/disabled at runtime by hardware/BIOS, so it's better LBR MSRs can be protected at runtime. The {rd,wr}ms