Re: [PATCH 2/3] vfs: dedupe: rationalize args

2018-05-07 Thread Miklos Szeredi
On Mon, May 7, 2018 at 1:16 PM, Matthew Wilcox wrote: > On Mon, May 07, 2018 at 10:21:07AM +0200, Miklos Szeredi wrote: >> @@ -1738,7 +1738,7 @@ struct file_operations { >> loff_t, size_t, unsigned int); >> int (*clone_file_range)(struct file *, loff_t, struct file *, l

Re: [PATCH 2/3] vfs: dedupe: rationalize args

2018-05-07 Thread Matthew Wilcox
On Mon, May 07, 2018 at 10:21:07AM +0200, Miklos Szeredi wrote: > @@ -1738,7 +1738,7 @@ struct file_operations { > loff_t, size_t, unsigned int); > int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t, > u64); > - s64 (*dedupe_fi

[PATCH 2/3] vfs: dedupe: rationalize args

2018-05-07 Thread Miklos Szeredi
Clean up f_op->dedupe_file_range() interface. 1) Use loff_t for offsets instead of u64 2) Order the arguments the same way as {copy|clone}_file_range(). Signed-off-by: Miklos Szeredi --- fs/btrfs/ctree.h | 4 ++-- fs/btrfs/ioctl.c | 4 ++-- fs/ocfs2/file.c| 6 +++--- fs/read_write.c