Re: [PATCH 2/3] timer: Check thread timers only when there are active thread timers

2015-08-26 Thread Jason Low
On Wed, 2015-08-26 at 13:04 -0400, George Spelvin wrote: > - check_thread_timers(tsk, &firing); > + if (!task_cputime_zero(&tsk->cputime_expires)) > + check_thread_timers(tsk, &firing); > > Sincere question; I'm not certain myself: would it make more sense to put > this shortcu

Re: [PATCH 2/3] timer: Check thread timers only when there are active thread timers

2015-08-26 Thread George Spelvin
- check_thread_timers(tsk, &firing); + if (!task_cputime_zero(&tsk->cputime_expires)) + check_thread_timers(tsk, &firing); Sincere question; I'm not certain myself: would it make more sense to put this shortcut into check_thread_timers()? It seems more like an optimizat

[PATCH 2/3] timer: Check thread timers only when there are active thread timers

2015-08-25 Thread Jason Low
The fastpath_timer_check() contains logic to check for if any timers are set by checking if !task_cputime_zero(). Similarly, we can do this before calling check_thread_timers(). In the case where there are only process-wide timers, this will skip all the computations for the per-thread timers when