Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-22 Thread Caesar Wang
在 2016年11月22日 15:57, Zhang Rui 写道: On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote: 在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid tem

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Zhang Rui
On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote: > 在 2016年11月19日 11:31, Caesar Wang 写道: > > > > Brian, > > > > 在 2016年11月19日 07:52, Brian Norris 写道: > > > > > > These error messages don't give much information about what went > > > wrong. > > > It would be nice, for one, to see what invalid

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Brian Norris
On Tue, Nov 22, 2016 at 10:33:27AM +0800, Caesar Wang wrote: > 在 2016年11月22日 10:15, Brian Norris 写道: > >On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote: > >>CHECK: Alignment should match open parenthesis > >>#428: FILE: drivers/thermal/rockchip_thermal.c:428: > >>+pr_err("%s: invali

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Caesar Wang
在 2016年11月22日 10:15, Brian Norris 写道: On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote: CHECK: Alignment should match open parenthesis #428: FILE: drivers/thermal/rockchip_thermal.c:428: +pr_err("%s: invalid temperature, temp=%d error=%d\n", +__func__, temp, error); CHECK

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Brian Norris
On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote: > CHECK: Alignment should match open parenthesis > #428: FILE: drivers/thermal/rockchip_thermal.c:428: > +pr_err("%s: invalid temperature, temp=%d error=%d\n", > +__func__, temp, error); > > CHECK: Alignment should match open

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Caesar Wang
在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-18 Thread Caesar Wang
在 2016年11月19日 11:31, Caesar Wang 写道: Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-18 Thread Caesar Wang
Brian, 在 2016年11月19日 07:52, Brian Norris 写道: These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion properly.

[PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-18 Thread Brian Norris
These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion properly. While we're at it, fix the grammar too. Signe