Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing

2007-08-01 Thread Scott Thompson
On Wed, 01 Aug 2007 06:38:16 -0400 Takashi Iwai <[EMAIL PROTECTED]> wrote: >This would be rater a lacking check of returned errors. > >The other changes look incorrect. All these drivers use >card->private_free callback to release the resources even for the >error exit. Thus, you don't need io

Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing

2007-08-01 Thread Takashi Iwai
At Wed, 01 Aug 2007 02:02:56 -0400, Scott Thompson wrote: > > ioremap / iounmap balancing in sound/pci tree > > Signed-off-by: Scott Thompson hushmail.com> > --- > diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c > index ac007ce..871b09f 100644 > --- a/sound/pci/mixart/mixart.c

[PATCH 2/3] sound/pci ioremap/iounmap balancing

2007-07-31 Thread Scott Thompson
ioremap / iounmap balancing in sound/pci tree Signed-off-by: Scott Thompson hushmail.com> --- diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c index ac007ce..871b09f 100644 --- a/sound/pci/mixart/mixart.c +++ b/sound/pci/mixart/mixart.c @@ -1319,6 +1319,13 @@ static int __devini