with Reviewed-by Lai Jiangshan added and Reviewed-by Josh Triplett
> corrected.
>
> From: Pranith Kumar
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
>
> This commit removes a stale comment in rcu/tree.c which was left out
stead. ;)
>
I apologize for fat-fingering this.
Since I've sent one too many emails in this thread already, I suppose on more
can not do much harm :)
This time with Reviewed-by Lai Jiangshan added and Reviewed-by Josh Triplett
corrected.
From: Pranith Kumar
Date: Mon, 14 Jul 2014 16:01:
16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
>
>
> This commit removes a stale comment in rcu/tree.c which was left out in
> commit 2036d94a7b61ca5032ce (rcu: Rework detection of use of RCU by offline
> CPUs)
>
> For reference, the following update
nt,
>>>>>> they mean the same :)
>>>>>>
>>>>>> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy.
>>>>>> */
>>>>>
>>>>> Indeed that is the case.
>>>>>
>>>>>
he rcu_node hierarchy.
>>>>> */
>>>>
>>>> Indeed that is the case.
>>>>
>>>> Please update the commit log with this explanation and resend.
>>>>
>>>>
mment which is below the old comment, they
>>>> mean the same :)
>>>>
>>>> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
>>>
>>> Indeed that is the case.
>>>
>>> Please update the commit log
t;> mean the same :)
>>>
>>> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
>>
>> Indeed that is the case.
>>
>> Please update the commit log with this explanation and resend.
>>
>> Thanx, Paul
>>
>
> Please f
ean the same :)
> >>
> >> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
> >
> > Indeed that is the case.
> >
> > Please update the commit log with this explanation and resend.
> >
> >
g with this explanation and resend.
>
> Thanx, Paul
>
Please find the updated patch below.
--
Pranith
From: Pranith Kumar
Date: Mon, 14 Jul 2014 16:01:05 -0400
Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
This c
On Tue, Jul 15, 2014 at 06:57:59PM -0400, Pranith Kumar wrote:
>
> On 07/15/2014 06:53 PM, j...@joshtriplett.org wrote:
> > On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote:
> >> This commit removes a stale comment in rcu/tree.c.
> >> FYI, an updated comment exists a few lines below t
On 07/15/2014 06:53 PM, j...@joshtriplett.org wrote:
> On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote:
>> This commit removes a stale comment in rcu/tree.c.
>> FYI, an updated comment exists a few lines below this.
>>
>> Signed-off-by: Pranith Kumar
> In general, when removing a st
On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote:
> This commit removes a stale comment in rcu/tree.c.
> FYI, an updated comment exists a few lines below this.
>
> Signed-off-by: Pranith Kumar
In general, when removing a stale comment, I'd suggest explaining why
the comment is stale
This commit removes a stale comment in rcu/tree.c.
FYI, an updated comment exists a few lines below this.
Signed-off-by: Pranith Kumar
---
kernel/rcu/tree.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index a1abaa8..e67246e 100644
--- a/kernel/rcu/t
13 matches
Mail list logo
