Re: [PATCH 2/3] printk: hard-code CONSOLE_LOGLEVEL_MIN in printk.c

2021-02-02 Thread Joe Perches
On Tue, 2021-02-02 at 19:06 +0900, Sergey Senozhatsky wrote: > On (21/02/02 16:02), Masahiro Yamada wrote: > >  include/linux/printk.h | 1 - > >  kernel/printk/printk.c | 2 +- > >  2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h

Re: [PATCH 2/3] printk: hard-code CONSOLE_LOGLEVEL_MIN in printk.c

2021-02-02 Thread Sergey Senozhatsky
On (21/02/02 16:02), Masahiro Yamada wrote: > include/linux/printk.h | 1 - > kernel/printk/printk.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index fd34b3aa2f90..ceaf0486c01c 100644 > --- a/include/linux/printk.h

[PATCH 2/3] printk: hard-code CONSOLE_LOGLEVEL_MIN in printk.c

2021-02-01 Thread Masahiro Yamada
CONSOLE_LOGLEVEL_MIN is only used in kernel/printk/printk.c. You do not need to expose it to all printk() users. I could move it to kernel/printk/printk.c, but I do not think this macro would contribute to the code readability or maintainability. I just hard-coded it. Signed-off-by: Masahiro Ya