Re: [PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2014-01-14 Thread Linus Walleij
On Thu, Jan 9, 2014 at 1:50 PM, Tomi Valkeinen wrote: > pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is > enabled. However, pcs_disable() always uses pcs->fmask. > > Fix pcs_disable() to use vals->mask with bits_per_mux. > > Signed-off-by: Tomi Valkeinen > Acked-by: Peter

[PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2014-01-09 Thread Tomi Valkeinen
pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is enabled. However, pcs_disable() always uses pcs->fmask. Fix pcs_disable() to use vals->mask with bits_per_mux. Signed-off-by: Tomi Valkeinen Acked-by: Peter Ujfalusi Acked-by: Tony Lindgren --- drivers/pinctrl/pinctrl-sin

Re: [PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2013-11-30 Thread Tony Lindgren
* Tony Lindgren [131130 09:08]: > * Peter Ujfalusi [131128 04:01]: > > On 11/28/2013 01:29 PM, Tomi Valkeinen wrote: > > > pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is > > > enabled. However, pcs_disable() always uses pcs->fmask. > > > > > > Fix pcs_disable() to use va

Re: [PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2013-11-30 Thread Tony Lindgren
* Peter Ujfalusi [131128 04:01]: > On 11/28/2013 01:29 PM, Tomi Valkeinen wrote: > > pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is > > enabled. However, pcs_disable() always uses pcs->fmask. > > > > Fix pcs_disable() to use vals->mask with bits_per_mux. > > I wonder how

Re: [PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2013-11-28 Thread Peter Ujfalusi
On 11/28/2013 01:29 PM, Tomi Valkeinen wrote: > pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is > enabled. However, pcs_disable() always uses pcs->fmask. > > Fix pcs_disable() to use vals->mask with bits_per_mux. I wonder how did I missed this? Acked-by: Peter Ujfalusi

[PATCH 2/3] pinctrl: single: fix pcs_disable with bits_per_mux

2013-11-28 Thread Tomi Valkeinen
pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is enabled. However, pcs_disable() always uses pcs->fmask. Fix pcs_disable() to use vals->mask with bits_per_mux. Signed-off-by: Tomi Valkeinen --- drivers/pinctrl/pinctrl-single.c | 10 -- 1 file changed, 8 insertions