Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-17 Thread Frederic Weisbecker
On Fri, Jan 17, 2014 at 04:56:18PM +0900, Namhyung Kim wrote: > Hi Arnaldo and Frederic, > > On Thu, 16 Jan 2014 17:47:34 -0200, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jan 16, 2014 at 06:34:58PM +0100, Frederic Weisbecker escreveu: > >> On Thu, Jan 16, 2014 at 10:17:53AM +0900, Namhyung Kim w

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-16 Thread Namhyung Kim
Hi Arnaldo and Frederic, On Thu, 16 Jan 2014 17:47:34 -0200, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 16, 2014 at 06:34:58PM +0100, Frederic Weisbecker escreveu: >> On Thu, Jan 16, 2014 at 10:17:53AM +0900, Namhyung Kim wrote: >> > I think if the sort key doesn't contain "symbol", unmatch ca

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 16, 2014 at 06:34:58PM +0100, Frederic Weisbecker escreveu: > On Thu, Jan 16, 2014 at 10:17:53AM +0900, Namhyung Kim wrote: > > I think if the sort key doesn't contain "symbol", unmatch case would be > > increased as more various callchains would go into a same entry. > > You mean -g

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-16 Thread Frederic Weisbecker
On Thu, Jan 16, 2014 at 10:17:53AM +0900, Namhyung Kim wrote: > I think if the sort key doesn't contain "symbol", unmatch case would be > increased as more various callchains would go into a same entry. You mean -g fractal,0.5,callee,address ? Hmm, actually I haven't seen much difference there.

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-15 Thread Namhyung Kim
Hi Frederic, On Wed, 15 Jan 2014 17:59:30 +0100, Frederic Weisbecker wrote: > On Wed, Jan 15, 2014 at 03:23:46PM +0900, Namhyung Kim wrote: >> On Tue, 14 Jan 2014 16:37:15 +0100, Frederic Weisbecker wrote: >> > When a new callchain child branch matches an existing one in the rbtree, >> > the compa

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-15 Thread Frederic Weisbecker
On Wed, Jan 15, 2014 at 03:23:46PM +0900, Namhyung Kim wrote: > On Tue, 14 Jan 2014 16:37:15 +0100, Frederic Weisbecker wrote: > > When a new callchain child branch matches an existing one in the rbtree, > > the comparison of its first entry is performed twice: > > > > 1) From append_chain_children

Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-14 Thread Namhyung Kim
On Tue, 14 Jan 2014 16:37:15 +0100, Frederic Weisbecker wrote: > When a new callchain child branch matches an existing one in the rbtree, > the comparison of its first entry is performed twice: > > 1) From append_chain_children() on branch lookup > > 2) If 1) reports a match, append_chain() then co

[PATCH 2/3] perf tools: Spare double comparison of callchain first entry

2014-01-14 Thread Frederic Weisbecker
When a new callchain child branch matches an existing one in the rbtree, the comparison of its first entry is performed twice: 1) From append_chain_children() on branch lookup 2) If 1) reports a match, append_chain() then compares all entries of the new branch against the matching node in the rbt