Re: [PATCH 2/3] msi: Fixup the msi enable/disable logic

2007-03-07 Thread Michael Ellerman
On Tue, 2007-03-06 at 22:19 -0700, Eric W. Biederman wrote: > Michael Ellerman <[EMAIL PROTECTED]> writes: > > > > > Hi Eric, comments below .. > > > > > > I get the reasoning for disabling MSI before we start writing back the > > config space, but don't we want to re-enable MSI on the way out? >

Re: [PATCH 2/3] msi: Fixup the msi enable/disable logic

2007-03-06 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > > Hi Eric, comments below .. > > > I get the reasoning for disabling MSI before we start writing back the > config space, but don't we want to re-enable MSI on the way out? We are restoring the entire msi flags register which includes the enable bit,

Re: [PATCH 2/3] msi: Fixup the msi enable/disable logic

2007-03-01 Thread Michael Ellerman
On Tue, 2007-02-27 at 12:31 -0700, Eric W. Biederman wrote: > enable/disable_msi_mode have several side effects which keeps them from > being generally useful. So this patch replaces them with with two > much more targeted functions: msi_set_enable and msix_set_enable. > > This patch makes pci_de

[PATCH 2/3] msi: Fixup the msi enable/disable logic

2007-02-27 Thread Eric W. Biederman
enable/disable_msi_mode have several side effects which keeps them from being generally useful. So this patch replaces them with with two much more targeted functions: msi_set_enable and msix_set_enable. This patch makes pci_dev->msi_enabled and pci_dev->msix_enabled the definitive way to test i