RE: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

2020-12-10 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, December 10, 2020 5:23 PM > > Or, keeping this member and then we check the product code by this member > > instead of switch() like below? > > > > /* No build test, JFYI */ > > struct bd957x_data *data_array[] = { > > &bd9571mwv_d

Re: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

2020-12-10 Thread Geert Uytterhoeven
Hi Shimoda-san, On Thu, Dec 10, 2020 at 5:10 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:26 PM > > On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda > > wrote: > > > > index 80c6ef0..57bdb6a 100644 > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b

RE: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

2020-12-09 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:26 PM > > Hi Shimoda-san, > > On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda > wrote: > > index 80c6ef0..57bdb6a 100644 > > --- a/drivers/mfd/bd9571mwv.c > > +++ b/drivers/mfd/bd9571mwv

Re: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

2020-12-09 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > Since the driver supports BD9571MWV PMIC only, > this patch makes the functions and data structure become more generic > so that it can support other PMIC variants as well. > > Signed-off-by: Khiem N

[PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

2020-12-08 Thread Yoshihiro Shimoda
From: Khiem Nguyen Since the driver supports BD9571MWV PMIC only, this patch makes the functions and data structure become more generic so that it can support other PMIC variants as well. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers/m