Re: [PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > If kernel_thread(kthread) succeeds, kthread() can not fail on its path to > complete(&create->started) + schedule(). After that it can't be woken because > nobody can see the new task yet. This means: > > - we don't need tasklist_lock for find_task

Re: [PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > > OK, I fixed that up. > > The next patch (make-kthread_stop-scalable) removes the find_task_by_pid() > anyway. Ok. Neat. I still need to review these a little more I have a different set of criteria, but it is interesting work.. > Our kthread creation

Re: [PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Andrew Morton
On Fri, 13 Apr 2007 15:51:29 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > > On Fri, 13 Apr 2007 17:02:01 +0400 > > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > >> If kernel_thread(kthread) succeeds, kthread() can not fail on its path to > >>

Re: [PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > On Fri, 13 Apr 2007 17:02:01 +0400 > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > >> If kernel_thread(kthread) succeeds, kthread() can not fail on its path to >> complete(&create->started) + schedule(). After that it can't be woken because >> nobody can se

Re: [PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Andrew Morton
On Fri, 13 Apr 2007 17:02:01 +0400 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > If kernel_thread(kthread) succeeds, kthread() can not fail on its path to > complete(&create->started) + schedule(). After that it can't be woken because > nobody can see the new task yet. This means: > > - we don

[PATCH 2/3] make kthread_create() more scalable

2007-04-13 Thread Oleg Nesterov
If kernel_thread(kthread) succeeds, kthread() can not fail on its path to complete(&create->started) + schedule(). After that it can't be woken because nobody can see the new task yet. This means: - we don't need tasklist_lock for find_task_by_pid(). - create_kthread() doesn't nee