Re: [PATCH 2/3] livepatch: Deny the patched modules to be removed

2018-06-11 Thread Miroslav Benes
On Mon, 11 Jun 2018, Petr Mladek wrote: > On Thu 2018-06-07 11:29:48, Miroslav Benes wrote: > > We decided to deny the patched modules to be removed. If it proves to be > > a major drawback for users, we can still implement a different approach. > > > > The reference of a patched module has to be

Re: [PATCH 2/3] livepatch: Deny the patched modules to be removed

2018-06-11 Thread Petr Mladek
On Thu 2018-06-07 11:29:48, Miroslav Benes wrote: > We decided to deny the patched modules to be removed. If it proves to be > a major drawback for users, we can still implement a different approach. > > The reference of a patched module has to be taken regardless of a > patch's state. Thus it is

[PATCH 2/3] livepatch: Deny the patched modules to be removed

2018-06-07 Thread Miroslav Benes
Josh reported a bug: When the object to be patched is a module, and that module is rmmod'ed and reloaded, it fails to load with: module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 2, loc ba0302e9, val a03e293c livepatch: failed to