Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-05 Thread Google
On Fri, 2 Aug 2024 17:09:12 + Song Liu wrote: > Hi Petr, > > > On Aug 2, 2024, at 8:45 AM, Petr Mladek wrote: > > [...] > > > > > IMHO, it depends on the use case. Let's keep "ping_table/" > > as an example. Why people would want to trace this function? > > There might be various reason

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-02 Thread Song Liu
> On Jul 29, 2024, at 5:54 PM, Song Liu wrote: > > With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names > to avoid duplication. This causes confusion with users of kallsyms. > On one hand, users like livepatch are required to match the symbols > exactly. On the other hand, use

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-02 Thread Song Liu
Hi Petr, > On Aug 2, 2024, at 8:45 AM, Petr Mladek wrote: [...] > > IMHO, it depends on the use case. Let's keep "ping_table/" > as an example. Why people would want to trace this function? > There might be various reasons, for example: > > 1. ping_table.llvm.15394922576589127018 appeared i

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-02 Thread Petr Mladek
On Wed 2024-07-31 01:00:34, Song Liu wrote: > Hi Masami, > > > On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: > > > > On Mon, 29 Jul 2024 17:54:32 -0700 > > Song Liu wrote: > > > >> With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names > >> to avoid duplication. This ca

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-02 Thread Google
Hi, Sorry for late reply. On Fri, 2 Aug 2024 03:45:42 + Song Liu wrote: > > > > On Aug 1, 2024, at 6:18 PM, Leizhen (ThunderTown) > > wrote: > > > > On 2024/7/31 9:00, Song Liu wrote: > >> Hi Masami, > >> > >>> On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: > >>> > >>> On Mon

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-01 Thread Leizhen (ThunderTown)
On 2024/8/2 11:45, Song Liu wrote: > > >> On Aug 1, 2024, at 6:18 PM, Leizhen (ThunderTown) >> wrote: >> >> On 2024/7/31 9:00, Song Liu wrote: >>> Hi Masami, >>> On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: On Mon, 29 Jul 2024 17:54:32 -0700 Song Liu wrote: >>>

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-01 Thread Song Liu
> On Aug 1, 2024, at 6:18 PM, Leizhen (ThunderTown) > wrote: > > On 2024/7/31 9:00, Song Liu wrote: >> Hi Masami, >> >>> On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: >>> >>> On Mon, 29 Jul 2024 17:54:32 -0700 >>> Song Liu wrote: >>> With CONFIG_LTO_CLANG=y, the compiler may

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-08-01 Thread Leizhen (ThunderTown)
On 2024/7/31 9:00, Song Liu wrote: > Hi Masami, > >> On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: >> >> On Mon, 29 Jul 2024 17:54:32 -0700 >> Song Liu wrote: >> >>> With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names >>> to avoid duplication. This causes confusion

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-07-30 Thread Song Liu
Hi Masami, > On Jul 30, 2024, at 6:03 AM, Masami Hiramatsu wrote: > > On Mon, 29 Jul 2024 17:54:32 -0700 > Song Liu wrote: > >> With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names >> to avoid duplication. This causes confusion with users of kallsyms. >> On one hand, users l

Re: [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-07-30 Thread Google
On Mon, 29 Jul 2024 17:54:32 -0700 Song Liu wrote: > With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names > to avoid duplication. This causes confusion with users of kallsyms. > On one hand, users like livepatch are required to match the symbols > exactly. On the other hand, use

[PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-07-29 Thread Song Liu
With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names to avoid duplication. This causes confusion with users of kallsyms. On one hand, users like livepatch are required to match the symbols exactly. On the other hand, users like kprobe would like to match to original function names