Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-12-04 Thread Tomasz Duszynski
On Mon, Dec 03, 2018 at 11:30:45AM +0100, Andreas Brauchli wrote: > From: Andreas Brauchli > > On Sat, 1 Dec 2018 15:58:57 +, Jonathan Cameron wrote: > > On Sun, 25 Nov 2018 20:05:09 +0100 > > Tomasz Duszynski wrote: > > > > > On Sun, Nov 25, 2018 at 08:56:59AM +, Jonathan Cameron wrote:

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-12-03 Thread Andreas Brauchli
From: Andreas Brauchli On Sat, 1 Dec 2018 15:58:57 +, Jonathan Cameron wrote: > On Sun, 25 Nov 2018 20:05:09 +0100 > Tomasz Duszynski wrote: > > > On Sun, Nov 25, 2018 at 08:56:59AM +, Jonathan Cameron wrote: > > > On Sat, 24 Nov 2018 23:14:14 +0100 > > > Tomasz Duszynski wrote: > > >

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-12-01 Thread Jonathan Cameron
On Mon, 26 Nov 2018 21:48:07 +0100 Tomasz Duszynski wrote: > On Sun, Nov 25, 2018 at 04:14:34PM +0530, Himanshu Jha wrote: > > On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > > > Add support for Sensirion SPS30 particulate matter sensor. > > > > > > Signed-off-by: Tomasz Dus

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-12-01 Thread Jonathan Cameron
On Sun, 25 Nov 2018 20:05:09 +0100 Tomasz Duszynski wrote: > On Sun, Nov 25, 2018 at 08:56:59AM +, Jonathan Cameron wrote: > > On Sat, 24 Nov 2018 23:14:14 +0100 > > Tomasz Duszynski wrote: > > > > > Add support for Sensirion SPS30 particulate matter sensor. > > > > > > Signed-off-by: Toma

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-26 Thread Tomasz Duszynski
On Sun, Nov 25, 2018 at 04:14:34PM +0530, Himanshu Jha wrote: > On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > > Add support for Sensirion SPS30 particulate matter sensor. > > > > Signed-off-by: Tomasz Duszynski > > --- > > drivers/iio/chemical/Kconfig | 11 ++ > > drivers/

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Tomasz Duszynski
On Sun, Nov 25, 2018 at 08:56:59AM +, Jonathan Cameron wrote: > On Sat, 24 Nov 2018 23:14:14 +0100 > Tomasz Duszynski wrote: > > > Add support for Sensirion SPS30 particulate matter sensor. > > > > Signed-off-by: Tomasz Duszynski > A few things inline. > > I'm particularly curious as to why w

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Himanshu Jha
On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/chemical/Kconfig | 11 ++ > drivers/iio/chemical/Makefile | 1 + > drivers/iio/chemical/sps30.c | 359 ++

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:14 +0100 Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski A few things inline. I'm particularly curious as to why we are ignoring two of the particle sizes that the sensor seems to capture? Also,

[PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-24 Thread Tomasz Duszynski
Add support for Sensirion SPS30 particulate matter sensor. Signed-off-by: Tomasz Duszynski --- drivers/iio/chemical/Kconfig | 11 ++ drivers/iio/chemical/Makefile | 1 + drivers/iio/chemical/sps30.c | 359 ++ 3 files changed, 371 insertions(+) create mode 10