Re: [PATCH 2/3] i2c: xilinx: Set tx direction in write operation

2013-09-30 Thread Michal Simek
On 09/30/2013 12:22 PM, Wolfram Sang wrote: > On Mon, Sep 30, 2013 at 11:08:51AM +0200, Michal Simek wrote: >> From: Kedareswara rao Appana >> >> In write operation, after filling address byte to tx fifo, >> set the direction of transfer to tx using control register. > > You describe WHAT you do,

Re: [PATCH 2/3] i2c: xilinx: Set tx direction in write operation

2013-09-30 Thread Wolfram Sang
On Mon, Sep 30, 2013 at 11:08:51AM +0200, Michal Simek wrote: > From: Kedareswara rao Appana > > In write operation, after filling address byte to tx fifo, > set the direction of transfer to tx using control register. You describe WHAT you do, yet you should describe WHY the change is needed. Fo

[PATCH 2/3] i2c: xilinx: Set tx direction in write operation

2013-09-30 Thread Michal Simek
From: Kedareswara rao Appana In write operation, after filling address byte to tx fifo, set the direction of transfer to tx using control register. Signed-off-by: Kedareswara rao Appana Signed-off-by: Michal Simek --- drivers/i2c/busses/i2c-xiic.c | 5 + 1 file changed, 5 insertions(+) d