Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-16 Thread OGAWA Hirofumi
Namjae Jeon writes: >> You have to think about compatibility with other FAT, not unix fs. > > Agreed, ctime is creation time, and there are comptability issues with > the patch. > > But there is confusion about 'ctime' usage in the default code. When > referring the code I found many instances ex

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-16 Thread Namjae Jeon
2012/11/15, OGAWA Hirofumi : > Namjae Jeon writes: > >> 1)If we consider the code for FAT and MSDOS to be same with respect to >> timing updates - there there is difference in code as mentioned below: >> a) For:vfat_rmdir() >> inode->i_mtime = inode->i_atime = CURRENT_TIME_SEC; >>For:msdo

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-14 Thread OGAWA Hirofumi
Namjae Jeon writes: > 1)If we consider the code for FAT and MSDOS to be same with respect to > timing updates - there there is difference in code as mentioned below: > a) For:vfat_rmdir() > inode->i_mtime = inode->i_atime = CURRENT_TIME_SEC; >For:msdos_rmdir() > inode->i_c

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-14 Thread Namjae Jeon
2012/11/12, OGAWA Hirofumi : > OGAWA Hirofumi writes: > >> Namjae Jeon writes: >> > What was difference with XFS, FAT, and MSDOS? >>> Okay, the description of patch was lacked, So I will resend patch with >>> specifical test reseult with other filesystem. BTW, I recall I checked thi

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-12 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: > Namjae Jeon writes: > What was difference with XFS, FAT, and MSDOS? >> Okay, the description of patch was lacked, So I will resend patch with >> specifical test reseult with other filesystem. >>> >>> BTW, I recall I checked this, and yes, it is strange. But it is hi

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-12 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> What was difference with XFS, FAT, and MSDOS? > Okay, the description of patch was lacked, So I will resend patch with > specifical test reseult with other filesystem. >> >> BTW, I recall I checked this, and yes, it is strange. But it is historical. > "historical" means It

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-12 Thread Namjae Jeon
2012/11/12, OGAWA Hirofumi : > OGAWA Hirofumi writes: > >> Namjae Jeon writes: >> >>> 2012/11/12, OGAWA Hirofumi : Namjae Jeon writes: > Correctly update modification and status change time in case of > file/directory removal and creation. This changelog just explain

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: > Namjae Jeon writes: > >> 2012/11/12, OGAWA Hirofumi : >>> Namjae Jeon writes: >>> Correctly update modification and status change time in case of file/directory removal and creation. >>> >>> This changelog just explain "what", and it doesn't explain "why". Ple

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2012/11/12, OGAWA Hirofumi : >> Namjae Jeon writes: >> >>> Correctly update modification and status change time in case of >>> file/directory removal and creation. >> >> This changelog just explain "what", and it doesn't explain "why". Please >> explain why we need this cha

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread Namjae Jeon
2012/11/12, OGAWA Hirofumi : > Namjae Jeon writes: > >> Correctly update modification and status change time in case of >> file/directory removal and creation. > > This changelog just explain "what", and it doesn't explain "why". Please > explain why we need this change. > > IIRC, timestamp handli

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread OGAWA Hirofumi
Namjae Jeon writes: > Correctly update modification and status change time in case of > file/directory removal and creation. This changelog just explain "what", and it doesn't explain "why". Please explain why we need this change. IIRC, timestamp handling in FAT driver is strange historically.

[PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread Namjae Jeon
Correctly update modification and status change time in case of file/directory removal and creation. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/dir.c|2 +- fs/fat/namei_vfat.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/fa