Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-25 Thread Chao Yu
On 2016/9/25 2:10, Jaegeuk Kim wrote: > On Sat, Sep 24, 2016 at 11:32:08AM +0800, Chao Yu wrote: >> On 2016/9/24 8:52, Jaegeuk Kim wrote: >>> On Sat, Sep 24, 2016 at 08:46:54AM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/9/24 7:53, Jaegeuk Kim wrote: > Hi Chao, > > The basi

Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-24 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 11:32:08AM +0800, Chao Yu wrote: > On 2016/9/24 8:52, Jaegeuk Kim wrote: > > On Sat, Sep 24, 2016 at 08:46:54AM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/9/24 7:53, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> The basic rule is to stop every operations once C

Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-23 Thread Chao Yu
On 2016/9/24 8:52, Jaegeuk Kim wrote: > On Sat, Sep 24, 2016 at 08:46:54AM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/9/24 7:53, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> The basic rule is to stop every operations once CP_ERROR_FLAG is set. >>> But, this patch simply breaks the rule. >>> For

Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-23 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 08:46:54AM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/9/24 7:53, Jaegeuk Kim wrote: > > Hi Chao, > > > > The basic rule is to stop every operations once CP_ERROR_FLAG is set. > > But, this patch simply breaks the rule. > > For example, f2fs_write_data_page() currently

Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-23 Thread Chao Yu
Hi Jaegeuk, On 2016/9/24 7:53, Jaegeuk Kim wrote: > Hi Chao, > > The basic rule is to stop every operations once CP_ERROR_FLAG is set. > But, this patch simply breaks the rule. > For example, f2fs_write_data_page() currently exits with mapping_set_error(). > So this patch incurs missing dentry bl

Re: [PATCH 2/3] f2fs: support checkpoint error injection

2016-09-23 Thread Jaegeuk Kim
Hi Chao, The basic rule is to stop every operations once CP_ERROR_FLAG is set. But, this patch simply breaks the rule. For example, f2fs_write_data_page() currently exits with mapping_set_error(). So this patch incurs missing dentry blocks in a valid checkpoint. Thanks, On Fri, Sep 23, 2016 at 0

[PATCH 2/3] f2fs: support checkpoint error injection

2016-09-22 Thread Chao Yu
This patch adds to support checkpoint error injection in f2fs for testing fatal error tolerance. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 7 +++ fs/f2fs/super.c | 1 + 2 files changed, 8 insertions(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index e216bc0..3c513fe 100644 --- a/fs/f2