Re: [PATCH 2/3] drivers: spi: Add qspi flash controller

2013-07-01 Thread Sourav Poddar
Hi Mark, Thanks for the review. Comments in lined. On Monday 01 July 2013 04:26 PM, Mark Brown wrote: On Wed, Jun 26, 2013 at 01:11:11PM +0530, Sourav Poddar wrote: +static int dra7xxx_qspi_prepare_xfer(struct spi_master *master) +{ + return 0; +} + +static int dra7xxx_qspi_unprepare_xfe

Re: [PATCH 2/3] drivers: spi: Add qspi flash controller

2013-07-01 Thread Mark Brown
On Wed, Jun 26, 2013 at 01:11:11PM +0530, Sourav Poddar wrote: > +static int dra7xxx_qspi_prepare_xfer(struct spi_master *master) > +{ > + return 0; > +} > + > +static int dra7xxx_qspi_unprepare_xfer(struct spi_master *master) > +{ > + return 0; > +} Remove empty functions, though... > +

Re: [PATCH 2/3] drivers: spi: Add qspi flash controller

2013-06-30 Thread Sourav Poddar
+ Artem On Wednesday 26 June 2013 01:11 PM, Sourav Poddar wrote: The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface fo

[PATCH 2/3] drivers: spi: Add qspi flash controller

2013-06-26 Thread Sourav Poddar
The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface for accessing data form external spi devices. The patch will configu