Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2

2019-01-12 Thread saiprakash . ranjan
Hi Mathieu, I think it would be better to simply mask out the minor version number bits in function etm4_arch_supported(). That way we can add more intelligence in there in the future if we have to and we don't have to touch the calling code again. Thanks for the review. Yes it seems good

Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2

2019-01-11 Thread Mathieu Poirier
On Wed, Jan 09, 2019 at 11:16:48PM +0530, Sai Prakash Ranjan wrote: > SDM845 has ETMv4.2 and can use the existing etm4x driver. > But the current etm driver checks only for ETMv4.0 and > errors out for other etm4x versions. This patch adds this > missing support to enable SoC's with ETMv4x to use s

[PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2

2019-01-09 Thread Sai Prakash Ranjan
SDM845 has ETMv4.2 and can use the existing etm4x driver. But the current etm driver checks only for ETMv4.0 and errors out for other etm4x versions. This patch adds this missing support to enable SoC's with ETMv4x to use same driver by checking only the ETM architecture major version number. With