Re: [PATCH 2/3] clk: let init callback return an error code

2019-09-29 Thread Heiko Stuebner
Am Dienstag, 24. September 2019, 14:39:53 CEST schrieb Jerome Brunet: > If the init callback is allowed to request resources, it needs a return > value to report the outcome of such a request. > > Signed-off-by: Jerome Brunet > --- [...] > drivers/clk/rockchip/clk-pll.c| 28 +

Re: [PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Andrew Lunn
On Tue, Sep 24, 2019 at 02:39:53PM +0200, Jerome Brunet wrote: > If the init callback is allowed to request resources, it needs a return > value to report the outcome of such a request. > > Signed-off-by: Jerome Brunet > --- > > Sorry about the spam. > This patch change quite a few files so I

RE: [PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Jerome Brunet
On Tue 24 Sep 2019 at 13:38, Ankur Tyagi wrote: > Hi, > > I am no expert here but just looked at the patch and found few > discrepancy that I have mentioned inline. > [...] > > Aren't all functions returning 0 always? > Yes, on purpose. This patch is an API conversion to let the init() callbac

RE: [PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Ankur Tyagi
lo...@lists.infradead.org; linux-arm-...@vger.kernel.org; linux- > rockc...@lists.infradead.org; linux-o...@vger.kernel.org > Subject: [PATCH 2/3] clk: let init callback return an error code > > If the init callback is allowed to request resources, it needs a return > value to report the o

[PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Jerome Brunet
If the init callback is allowed to request resources, it needs a return value to report the outcome of such a request. Signed-off-by: Jerome Brunet --- Sorry about the spam. This patch change quite a few files so I have tried to Cc the relevant people. Stephen, You may notice that I have adde