Re: [PATCH 2/3] PCI: qcom: Don't unroll init if init fails

2017-08-03 Thread Stanimir Varbanov
Hi, The patch looks correct. On 07/16/2017 09:39 AM, Bjorn Andersson wrote: > When the init op fails it will restore the state of the resources, so we > should not disable them one more time when this happens. > > Signed-off-by: Bjorn Andersson > --- > drivers/pci/dwc/pcie-qcom.c | 2 +- > 1 f

Re: [PATCH 2/3] PCI: qcom: Don't unroll init if init fails

2017-08-02 Thread Bjorn Helgaas
On Sat, Jul 15, 2017 at 11:41:53PM -0700, Bjorn Andersson wrote: > When the init op fails it will restore the state of the resources, so we > should not disable them one more time when this happens. > > Signed-off-by: Bjorn Andersson Stanimir, any opinion on this and the following patch? > ---

[PATCH 2/3] PCI: qcom: Don't unroll init if init fails

2017-07-15 Thread Bjorn Andersson
When the init op fails it will restore the state of the resources, so we should not disable them one more time when this happens. Signed-off-by: Bjorn Andersson --- drivers/pci/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/dwc/pcie-qcom.c b/drive

[PATCH 2/3] PCI: qcom: Don't unroll init if init fails

2017-07-15 Thread Bjorn Andersson
When the init op fails it will restore the state of the resources, so we should not disable them one more time when this happens. Signed-off-by: Bjorn Andersson --- drivers/pci/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/dwc/pcie-qcom.c b/drive