Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Yinghai Lu
On Fri, Oct 12, 2012 at 11:34 AM, Yinghai Lu wrote: > On Fri, Oct 12, 2012 at 3:54 AM, Jiang Liu wrote: >> On 2012-10-12 18:42, Tang Chen wrote: >>> On 10/12/2012 06:36 PM, Jiang Liu wrote: I have sent a similar patch to Yinghai before. For simplicity, we could use acpi_match_object_inf

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Yinghai Lu
On Fri, Oct 12, 2012 at 3:54 AM, Jiang Liu wrote: > On 2012-10-12 18:42, Tang Chen wrote: >> On 10/12/2012 06:36 PM, Jiang Liu wrote: >>> I have sent a similar patch to Yinghai before. For simplicity, we could >>> use acpi_match_object_info_ids() instead of acpi_match_device_ids() >>> directly. >>

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
On 10/12/2012 06:54 PM, Jiang Liu wrote: I have sent a similar patch to Yinghai before. For simplicity, we could use acpi_match_object_info_ids() instead of acpi_match_device_ids() directly. Hum, I must have missed it. :) Using acpi_match_object_info_ids() directly seems good. I'm just worry ab

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Jiang Liu
On 2012-10-12 18:42, Tang Chen wrote: > On 10/12/2012 06:36 PM, Jiang Liu wrote: >> On 2012-10-12 18:31, Tang Chen wrote: >>> When the kernel is being initialized, and some hardwares are not added >>> to system, there won't be acpi_device structs for these devices. But >>> acpi_is_root_bridge() dep

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
On 10/12/2012 06:36 PM, Jiang Liu wrote: On 2012-10-12 18:31, Tang Chen wrote: When the kernel is being initialized, and some hardwares are not added to system, there won't be acpi_device structs for these devices. But acpi_is_root_bridge() depends on acpi_device struct. As a result, all the not

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Jiang Liu
On 2012-10-12 18:31, Tang Chen wrote: > When the kernel is being initialized, and some hardwares are not added > to system, there won't be acpi_device structs for these devices. But > acpi_is_root_bridge() depends on acpi_device struct. As a result, all > the not-added root bridge will not be judge

[PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
When the kernel is being initialized, and some hardwares are not added to system, there won't be acpi_device structs for these devices. But acpi_is_root_bridge() depends on acpi_device struct. As a result, all the not-added root bridge will not be judged as a root bridge in find_root_bridges(). And