Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver

2018-12-17 Thread Michal Simek
On 17. 12. 18 13:24, Mark Brown wrote: > On Fri, Dec 14, 2018 at 07:50:43AM +0100, Michal Simek wrote: >> On 13. 12. 18 16:31, Mark Brown wrote: >>> On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu >>> wrote: > @@ -0,0 +1,185 @@ +// SPDX-License-Identifier: GPL-2.0

Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver

2018-12-17 Thread Mark Brown
On Fri, Dec 14, 2018 at 07:50:43AM +0100, Michal Simek wrote: > On 13. 12. 18 16:31, Mark Brown wrote: > > On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu > > wrote: > >> @@ -0,0 +1,185 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Xilinx ASoC I2S audio sup

Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver

2018-12-13 Thread Michal Simek
Hi Mark, On 13. 12. 18 16:31, Mark Brown wrote: > On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu wrote: > >> @@ -0,0 +1,185 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Xilinx ASoC I2S audio support >> + * > > This looks otherwise good so I've applied it but p

Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver

2018-12-13 Thread Mark Brown
On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu wrote: > @@ -0,0 +1,185 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Xilinx ASoC I2S audio support > + * This looks otherwise good so I've applied it but please send a followup patch converting the entire comment bloc

[PATCH 2/3] ASoC: xlnx: Add i2s driver

2018-12-07 Thread Maruthi Srinivas Bayyavarapu
I2S IP instance can work in transmitter/playback or receiver/capture mode exclusively. The patch registers corresponding instance as ASoC component with audio framework. Signed-off-by: Maruthi Srinivas Bayyavarapu --- sound/soc/xilinx/xlnx_i2s.c | 185 +++