Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-25 Thread Jeremy McDermond
> On Apr 25, 2016, at 5:55 AM, Mark Brown wrote: > > If the clock code is worth splitting off into a separate driver that's > what drivers/mfd is for. I have my doubts that it’s worth splitting off into a separate driver. There’s not a lot of use for it outside of the internals of the tlv320ai

Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-25 Thread Mark Brown
On Fri, Apr 22, 2016 at 09:37:39AM -0700, Jeremy McDermond wrote: > components fairly well. I’m just trying to wrap my head around > where this all would fit in. Should the codec driver just register > a bunch of clock components in its initialization somewhere? > I’m thinking that it can’t have

Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-22 Thread Jeremy McDermond
> On Apr 22, 2016, at 2:22 AM, Mark Brown wrote: > > On Fri, Apr 22, 2016 at 09:17:46AM +0800, Xing Zheng wrote: > >> Hi Mark, the other question here, how do we make sense to use the >> simple-card to call the "snd_soc_dai_set_pll" if the codec (like da7219) >> requires do this? > > What we s

Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-22 Thread Jeremy McDermond
> On Apr 22, 2016, at 2:22 AM, Mark Brown wrote: > > On Fri, Apr 22, 2016 at 09:17:46AM +0800, Xing Zheng wrote: > >> Hi Mark, the other question here, how do we make sense to use the >> simple-card to call the "snd_soc_dai_set_pll" if the codec (like da7219) >> requires do this? > > What we s

Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-22 Thread Mark Brown
On Fri, Apr 22, 2016 at 09:17:46AM +0800, Xing Zheng wrote: > Hi Mark, the other question here, how do we make sense to use the > simple-card to call the "snd_soc_dai_set_pll" if the codec (like da7219) > requires do this? What we should do there is move the CODEC clocking to be represented using

Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-21 Thread Xing Zheng
On 2016年04月21日 22:19, Rob Herring wrote: On Mon, Apr 18, 2016 at 04:17:31PM +0800, Xing Zheng wrote: In most cases, many codecs already supports jack detection, previouslly, we need to create a customized machine driver every time. Hence, the simple-card need to support use them dynamically vi

Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-21 Thread Rob Herring
On Mon, Apr 18, 2016 at 04:17:31PM +0800, Xing Zheng wrote: > In most cases, many codecs already supports jack detection, previouslly, > we need to create a customized machine driver every time. > > Hence, the simple-card need to support use them dynamically via parse dts > file for better flexibi

[PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

2016-04-18 Thread Xing Zheng
In most cases, many codecs already supports jack detection, previouslly, we need to create a customized machine driver every time. Hence, the simple-card need to support use them dynamically via parse dts file for better flexibility. Signed-off-by: Xing Zheng --- .../devicetree/bindings/sound/