Re: [PATCH 2/3] ASoC: codecs: Add aw8898 amplifier driver

2025-04-06 Thread Mark Brown
On Sun, Apr 06, 2025 at 03:03:16PM +0200, Luca Weiss wrote: Overall this driver feels like it's not terribly well integrated into the subsystem - it's not using the standard framework features for things. The code itself looks broadly fine but things need moving about a bit to feel more like a st

Re: [PATCH 2/3] ASoC: codecs: Add aw8898 amplifier driver

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 15:03, Luca Weiss wrote: > +static const struct i2c_device_id aw8898_id[] = { > + { "aw8898" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(i2c, aw8898_id); > + > +static const struct of_device_id aw8898_of_match[] = { > + { .compatible = "awinic,aw8898" }, > +

[PATCH 2/3] ASoC: codecs: Add aw8898 amplifier driver

2025-04-06 Thread Luca Weiss
Add a driver for the AW8898 Audio Amplifier. Signed-off-by: Luca Weiss --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 1 + sound/soc/codecs/snd-soc-aw8898.c | 583 ++ 3 files changed, 594 insertions(+) diff --git a/sound/