Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Janne Kanniainen
2014-07-03 21:17 GMT+03:00 Bryan Wu : > On Thu, Jul 3, 2014 at 10:40 AM, Johan Hovold wrote: >> On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: >>> Move led_mode attribute from HID device to led-class devices and rename >>> it msi_mode. This will also fix race condition by using

Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Bryan Wu
On Thu, Jul 3, 2014 at 10:40 AM, Johan Hovold wrote: > On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: >> Move led_mode attribute from HID device to led-class devices and rename >> it msi_mode. This will also fix race condition by using > > There's a typo here (s/msi_mode/mode) b

Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Johan Hovold
On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices and rename > it msi_mode. This will also fix race condition by using There's a typo here (s/msi_mode/mode) but perhaps Bryan can just fix that up before applying? > att

[PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Janne Kanniainen
Move led_mode attribute from HID device to led-class devices and rename it msi_mode. This will also fix race condition by using attribute-groups. Signed-off-by: Janne Kanniainen --- Changes in v3: - Style fixes - Rename sysfs-class-hid-driver-gt683r to sysfs-class-leds-driver-gt6