Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-07-02 Thread Jiri Kosina
On Tue, 1 Jul 2014, Bryan Wu wrote: > Great, I just cherry-picked and applied to my tree > http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/commit/?h=for-next&id=f471d9480275796dea2ac7ec249b050e70a2888d Ok, perfect, thanks. I am marking my 'for-3.17/hid-gt683r' so that it woul

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-07-01 Thread Janne Kanniainen
> Great, I just cherry-picked and applied to my tree > http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/commit/?h=for-next&id=f471d9480275796dea2ac7ec249b050e70a2888d > > Thanks, > -Bryan Ok, thank you! Janne -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-07-01 Thread Bryan Wu
On Tue, Jul 1, 2014 at 1:48 AM, Johan Hovold wrote: > On Mon, Jun 30, 2014 at 04:17:10PM -0700, Bryan Wu wrote: >> On Mon, Jun 30, 2014 at 4:33 AM, Jiri Kosina wrote: >> > On Mon, 30 Jun 2014, Johan Hovold wrote: >> > >> >> > I think the better place is HID/input tree, since this patch depends >>

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-07-01 Thread Johan Hovold
On Mon, Jun 30, 2014 at 04:17:10PM -0700, Bryan Wu wrote: > On Mon, Jun 30, 2014 at 4:33 AM, Jiri Kosina wrote: > > On Mon, 30 Jun 2014, Johan Hovold wrote: > > > >> > I think the better place is HID/input tree, since this patch depends > >> > on the initial one which is not in my tree. > >> > I'm

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Bryan Wu
On Mon, Jun 30, 2014 at 4:33 AM, Jiri Kosina wrote: > On Mon, 30 Jun 2014, Johan Hovold wrote: > >> > I think the better place is HID/input tree, since this patch depends >> > on the initial one which is not in my tree. >> > I'm going to merge Johan's whole patchset and this patch probably >> > de

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Jiri Kosina
On Mon, 30 Jun 2014, Johan Hovold wrote: > > I think the better place is HID/input tree, since this patch depends > > on the initial one which is not in my tree. > > I'm going to merge Johan's whole patchset and this patch probably > > depends Johan's work too. > > Dmitry has ACKed the input-patc

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Johan Hovold
On Wed, Jun 25, 2014 at 03:55:10PM -0700, Bryan Wu wrote: > On Wed, Jun 25, 2014 at 12:09 PM, Jiri Kosina wrote: > > On Wed, 25 Jun 2014, Johan Hovold wrote: > > > >> Did you see the attribute-race series I posted? Not sure how best to > >> handle the dependency, as those patches should probably g

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-25 Thread Bryan Wu
On Wed, Jun 25, 2014 at 12:09 PM, Jiri Kosina wrote: > On Wed, 25 Jun 2014, Johan Hovold wrote: > >> Did you see the attribute-race series I posted? Not sure how best to >> handle the dependency, as those patches should probably go in through >> the LEDs tree, while the first patch in that series

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-25 Thread Jiri Kosina
On Wed, 25 Jun 2014, Johan Hovold wrote: > Did you see the attribute-race series I posted? Not sure how best to > handle the dependency, as those patches should probably go in through > the LEDs tree, while the first patch in that series (adding the groups > field) is a dependency for this patch.

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-25 Thread Johan Hovold
On Wed, Jun 25, 2014 at 06:59:26PM +0300, Janne Kanniainen wrote: > Use attribute-groups to fix race condition. The primary thing you're doing here is moving and renaming the attribute to the led class devices, so you need to mention that (and update the patch subject). But you can mention the rac

[PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-25 Thread Janne Kanniainen
Use attribute-groups to fix race condition. Signed-off-by: Janne Kanniainen --- .../ABI/testing/sysfs-class-hid-driver-gt683r | 6 +++-- drivers/hid/hid-gt683r.c | 31 +- 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/Document