Re: [PATCH 2/2 resend] mm: various cleanups in get_user_pages()

2008-02-12 Thread Eugene Teo
Hi Nick, Thanks for the review. > On Wednesday 13 February 2008 00:10, Eugene Teo wrote: [...] > > diff --git a/mm/memory.c b/mm/memory.c > > index 54f951b..c7e0610 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -1003,7 +1003,9 @@ int get_user_pages(struct task_struct *tsk, struct > >

Re: [PATCH 2/2 resend] mm: various cleanups in get_user_pages()

2008-02-12 Thread Nick Piggin
On Wednesday 13 February 2008 00:10, Eugene Teo wrote: > Sorry for the repeated emails. Kindly ignore the previous resend. Please > review this instead. Thanks. I have tested this. If it is causing this much problems, can you split the cleanups into their own patches. > [PATCH 2/2] mm: various c

Re: [PATCH 2/2 resend] mm: various cleanups in get_user_pages()

2008-02-12 Thread Eugene Teo
Sorry for the repeated emails. Kindly ignore the previous resend. Please review this instead. Thanks. I have tested this. [PATCH 2/2] mm: various cleanups in get_user_pages() This patch contains various cleanups, including making sure vma is valid, and the return value of follow_hugetlb_page() i

[PATCH 2/2 resend] mm: various cleanups in get_user_pages()

2008-02-12 Thread Eugene Teo
Argh. Sorry, I spotted a mistake. Here's a resend: [PATCH 2/2] mm: various cleanups in get_user_pages() This patch contains various cleanups, including making sure vma is valid, and the return value of follow_hugetlb_page() is validated. Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> --- mm/memo