Re: [PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare

2015-05-05 Thread Dave Chinner
On Tue, May 05, 2015 at 09:38:07PM -0700, Christoph Hellwig wrote: > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > > index 02f827f..900f8ce 100644 > > --- a/fs/xfs/xfs_mount.c > > +++ b/fs/xfs/xfs_mount.c > > @@ -1106,8 +1106,9 @@ xfs_mod_icount( > > int64_t delta) >

Re: [PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare

2015-05-05 Thread Christoph Hellwig
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index 02f827f..900f8ce 100644 > --- a/fs/xfs/xfs_mount.c > +++ b/fs/xfs/xfs_mount.c > @@ -1106,8 +1106,9 @@ xfs_mod_icount( > int64_t delta) > { > /* deltas are +/-64, hence the large batch size of 128. */ > -

[PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare

2015-05-05 Thread Dave Chinner
From: Dave Chinner From: Dave Chinner Because the counter uses a custom batch size, the comparison function needs to be aware of that batch size otherwise the comparison does not work correctly. This leads to ASSERT failures on generic/027 like this: XFS: Assertion failed: 0, file: fs/xfs/xfs