Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-05-05 Thread Reinette Chatre
Hi Borislav, On 5/4/2020 9:19 PM, Reinette Chatre wrote: > On 5/4/2020 12:56 AM, Borislav Petkov wrote: >> Hi, >> >> On Sun, May 03, 2020 at 11:51:00AM -0700, Reinette Chatre wrote: >>> I am struggling with what should follow ... >> >> Since a diff is better than a thousand words :-) see below. >>

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-05-04 Thread Reinette Chatre
Hi Borislav, On 5/4/2020 12:56 AM, Borislav Petkov wrote: > Hi, > > On Sun, May 03, 2020 at 11:51:00AM -0700, Reinette Chatre wrote: >> I am struggling with what should follow ... > > Since a diff is better than a thousand words :-) see below. > Thank you so much for providing the details. You

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-05-04 Thread Borislav Petkov
Hi, On Sun, May 03, 2020 at 11:51:00AM -0700, Reinette Chatre wrote: > I am struggling with what should follow ... Since a diff is better than a thousand words :-) see below. It builds here with my .config but I'm sure it still needs work but you get the idea. When you do the final version, plea

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-05-03 Thread Reinette Chatre
Hi Borislav, On 4/30/2020 2:59 AM, Borislav Petkov wrote: > On Wed, Apr 29, 2020 at 11:42:03AM -0700, Reinette Chatre wrote: >> This would essentially be resubmitting [1] though. Do you expect that >> this change would receive a different reception at this time? > > Right, Thomas and I talked it

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-04-30 Thread Borislav Petkov
On Wed, Apr 29, 2020 at 11:42:03AM -0700, Reinette Chatre wrote: > This would essentially be resubmitting [1] though. Do you expect that > this change would receive a different reception at this time? Right, Thomas and I talked it over a bit last night. So the proper thing to do is to read all tha

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-04-29 Thread Reinette Chatre
Hi Borislav, On 4/29/2020 11:11 AM, Borislav Petkov wrote: > On Wed, Apr 01, 2020 at 10:51:02AM -0700, Reinette Chatre wrote: >> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c >> index 4cdb123ff66a..8552d2fadc15 100644 >> --- a/arch/x86/kernel/cpu/common.c >> +++ b/arch/x

Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM counter width

2020-04-29 Thread Borislav Petkov
On Wed, Apr 01, 2020 at 10:51:02AM -0700, Reinette Chatre wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 4cdb123ff66a..8552d2fadc15 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -856,6 +856,8 @@ static void init_spec