Re: [PATCH 2/2] x86/hibernate/64: Mask off CR3's PCID bits in the saved CR3

2017-09-10 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Fri, Sep 8, 2017 at 12:59 AM, Jiri Kosina wrote: > > On Thu, 7 Sep 2017, Andy Lutomirski wrote: > > > >> Jiri reported a resume-from-hibernation failure triggered by PCID. > >> The root cause appears to be rather odd. The hibernation asm > >> restores a CR3 value

Re: [PATCH 2/2] x86/hibernate/64: Mask off CR3's PCID bits in the saved CR3

2017-09-10 Thread Andy Lutomirski
On Fri, Sep 8, 2017 at 12:59 AM, Jiri Kosina wrote: > On Thu, 7 Sep 2017, Andy Lutomirski wrote: > >> Jiri reported a resume-from-hibernation failure triggered by PCID. >> The root cause appears to be rather odd. The hibernation asm >> restores a CR3 value that comes from the image header. If th

Re: [PATCH 2/2] x86/hibernate/64: Mask off CR3's PCID bits in the saved CR3

2017-09-08 Thread Jiri Kosina
On Thu, 7 Sep 2017, Andy Lutomirski wrote: > Jiri reported a resume-from-hibernation failure triggered by PCID. > The root cause appears to be rather odd. The hibernation asm > restores a CR3 value that comes from the image header. If the image > kernel has PCID on, it's entirely reasonable for

[PATCH 2/2] x86/hibernate/64: Mask off CR3's PCID bits in the saved CR3

2017-09-07 Thread Andy Lutomirski
Jiri reported a resume-from-hibernation failure triggered by PCID. The root cause appears to be rather odd. The hibernation asm restores a CR3 value that comes from the image header. If the image kernel has PCID on, it's entirely reasonable for this CR3 value to have one of the low 12 bits set.